feat(ctb): simplify XDM initialization#3443
Merged
mergify[bot] merged 1 commit intodevelopfrom Sep 16, 2022
Merged
Conversation
🦋 Changeset detectedLatest commit: 8f7d008 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
2-reviewers
A-pkg-contracts-bedrock
Contributor
|
I think this will also need changes in the go L1 genesis creation code |
smartcontracts
force-pushed
the
sc/ctb-simplify-init
branch
from
cb693be to
6fdaf4f
Compare
smartcontracts
requested review from
maurelian and
tynes
and removed request for
tynes
smartcontracts
force-pushed
the
sc/ctb-simplify-init
branch
from
6fdaf4f to
37dd389
Compare
Contributor
|
Hey @smartcontracts! This PR has merge conflicts. Please fix them before continuing review. |
smartcontracts
force-pushed
the
sc/ctb-simplify-init
branch
from
37dd389 to
4d127f9
Compare
maurelian
reviewed
Sep 15, 2022
smartcontracts
force-pushed
the
sc/ctb-simplify-init
branch
2 times, most recently
from
9e0e7f9 to
c208791
Compare
Contributor
🤔 |
Contributor
Author
Investigating.... |
Contributor
Author
|
Same bug as before. Opening a PR to make OptimismPortal not payable. |
Contributor
|
Hey @smartcontracts! This PR has merge conflicts. Please fix them before continuing review. |
smartcontracts
force-pushed
the
sc/ctb-simplify-init
branch
from
c208791 to
ab60e8c
Compare
maurelian
approved these changes
Sep 15, 2022
smartcontracts
force-pushed
the
sc/ctb-simplify-init
branch
from
ab60e8c to
292dc80
Compare
tynes
approved these changes
Sep 16, 2022
Contributor
|
This PR has been added to the merge queue, and will be merged soon. |
Contributor
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
Contributor
|
Merge failed. Please see automated check logs for more details. |
Simplifies XDM initialization by moving all input variables into the constructor. This was the best I could do, we still need an initializer because of the stuff that the base contract inherits. The primary benefit of this change is that it means we never have to put any parameters into the initializer, which means we can be very certain about parameters before we perform the upgrade.
smartcontracts
force-pushed
the
sc/ctb-simplify-init
branch
from
78d903a to
8f7d008
Compare
Contributor
|
This PR has been added to the merge queue, and will be merged soon. |
Contributor
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Simplifies XDM initialization by moving all input variables into the constructor. This was the best I could do, we still need an initializer because of the stuff that the base contract inherits. The primary benefit of this change is that it means we never have to put any parameters into the initializer, which means we can be very certain about parameters before we perform the upgrade.
Tests
Core functionality is not changing and tests continue to pass.